Skip to content

gh-133379: Correct usage of arguments in error messages #133382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 10, 2025

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented May 4, 2025

Not quite sure what the title should be for this.

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title looks great to me

@picnixz
Copy link
Member

picnixz commented May 4, 2025

The title could be about correcting the places where the term argument is incorrectly used, but your title is fine.

@serhiy-storchaka
Copy link
Member

What is the difference between #133382 and #133463?

@StanFromIreland
Copy link
Member Author

Other error messages are corrected.

@picnixz
Copy link
Member

picnixz commented May 9, 2025

Following #133463 (comment), I suggest we fix everything here.

@StanFromIreland
Copy link
Member Author

All complete, I included @serhiy-storchaka extra example and two more I found. Added an entry to whatsnew since this affects quite a few error messages.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka merged commit dbca27c into python:main May 10, 2025
39 checks passed
@StanFromIreland StanFromIreland deleted the correct-errors branch May 10, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants