Skip to content

gh-74468: Fix name attribute of extracted object #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

xondrejk
Copy link

@xondrejk xondrejk commented May 5, 2017

Attribute name of the extracted file object should hold filename of
itself rather than then of the archive it is contained in.

Attribute name of the extracted file object should hold filename of
itself rather than then of the archive it is contained in.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@xondrejk
Copy link
Author

xondrejk commented May 5, 2017

Out of multiple options to tackle this, I've opted to not add another argument to _FileInFile retrieving the value for tarinfo.name on call and instead pass complete TarInfo instance and get the data from that. It seems to be OK with respect to the immediate state of code in the repo. I hope it's not too far off and move in the wrong direction.

Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add tests & release notes to ensure these changes won't create any regression

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 19, 2022
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 28, 2022
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 28, 2022
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See @auvipy’s comment at #1483 (review)

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Nov 30, 2022
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 31, 2022
@erlend-aasland erlend-aasland added the pending The issue will be closed if no feedback is provided label Feb 21, 2023
@erlend-aasland
Copy link
Contributor

No response since Irit commented; marked as pending close.

@erlend-aasland erlend-aasland changed the title bpo-30282: Fix name attribute of extracted object gh-74468: Fix name attribute of extracted object Feb 21, 2023
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Feb 22, 2023
@arhadthedev arhadthedev self-assigned this Mar 4, 2023
@arhadthedev arhadthedev added stdlib Python modules in the Lib dir and removed pending The issue will be closed if no feedback is provided labels Mar 4, 2023
@arhadthedev arhadthedev requested a review from ethanfurman as a code owner March 4, 2023 17:41
@ghost
Copy link

ghost commented Mar 4, 2023

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

@arhadthedev arhadthedev removed their assignment Mar 4, 2023
@arhadthedev
Copy link
Member

arhadthedev commented Mar 4, 2023

The OP had no PR/issue/review activity for last three years. I'll create an alternative fix an altered PR to successfully close the issue despite the unsigned CLA.

@erlend-aasland
Copy link
Contributor

Superseded by #102424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes stdlib Python modules in the Lib dir
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

10 participants