bpo-39481: Make functools.cached_property, partial, ...

[emmatyping]

... partialmethod, _lru_cache_wrapper generic.

I noticed that _lru_cache_wrapper's Python implementation is a function, what should be done about that? I feel like it would be weird to have code that runs without the compiled functools to break on a subscripted lru_cache. Perhaps it should be a class instead?

https://bugs.python.org/issue39481

[gvanrossum]

The conflicts are really annoying. I think we should merge these one at a time and then resolve conflicts in one following PR and land that before merging the next one. That will take a lot of time, because each time we must wait for the tests... :-(

[gvanrossum]

I noticed that _lru_cache_wrapper's Python implementation is a function, what should be done about that? I feel like it would be weird to have code that runs without the compiled functools to break on a subscripted lru_cache. Perhaps it should be a class instead?

Based on this I withdraw my approval. @rhettinger what do you think?

@ethanhs If you want to make progress, remove _lru_cache_wrapper from this PR?

[gvanrossum]

_lru_cache_wrapper issue.

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[rhettinger]

I suggest omitting the lru_cache() for now.

Also, it would be nice to have a few tests.

[emmatyping]

@rhettinger Okay, sounds good, I will remove the lru_cache change, that can be done in a follow up. As for tests, I added the modified types to the GenericAlias tests that check they are subscriptable here: https://github.com/python/cpython/pull/19427/files#diff-f3accc4cfc3724113e786a2ba3548f35R27

Edit: that link seems broken, but in test_genericalias.py, there are tests for all the relevant types.

Did you have other tests in mind?

[emmatyping]

I have made the requested changes; please review again

[bedevere-bot]

Thanks for making the requested changes!

@gvanrossum: please review the changes made to this pull request.

[gvanrossum]

I think Raymond should be happy, so I'll merge now.

[bedevere-bot]

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!