Skip to content

bpo-40334: Rename PyConfig.use_peg to _use_peg_parser #19670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2020
Merged

bpo-40334: Rename PyConfig.use_peg to _use_peg_parser #19670

merged 3 commits into from
Apr 23, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 23, 2020

  • Rename PyConfig.use_peg to _use_peg_parser
  • Document PyConfig._use_peg_parser and mark it a deprecated
  • Mark -X oldparser option and PYTHONOLDPARSER env var as deprecated
    in the documentation.
  • Add use_old_parser() and skip_if_new_parser() to test.support
  • Remove sys.flags.use_peg: use_old_parser() uses
    _testinternalcapi.get_configs() instead.
  • Enhance test_embed tests

https://bugs.python.org/issue40334

* Rename PyConfig.use_peg to _use_peg_parser
* Document PyConfig._use_peg_parser and mark it a deprecated
* Mark -X oldparser option and PYTHONOLDPARSER env var as deprecated
  in the documentation.
* Add use_old_parser() and skip_if_new_parser() to test.support
* Remove sys.flags.use_peg: use_old_parser() uses
  _testinternalcapi.get_configs() instead.
* Enhance test_embed tests
@vstinner
Copy link
Member Author

See also PR #19669.

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really much better. Thanks!

@vstinner vstinner requested a review from gpshead as a code owner April 23, 2020 00:37
@vstinner vstinner merged commit 1def775 into python:master Apr 23, 2020
@vstinner vstinner deleted the pyconfig_peg branch April 23, 2020 01:03
terryjreedy added a commit that referenced this pull request Jun 5, 2020
A tiny sliver of a 3.9 PEG parser patch needed to backport the test added by #20486.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 5, 2020
A tiny sliver of a 3.9 PEG parser patch needed to backport the test added by pythonGH-20486.
(cherry picked from commit a5d6aba)

Co-authored-by: Terry Jan Reedy <[email protected]>
terryjreedy added a commit that referenced this pull request Jun 5, 2020
A tiny sliver of a 3.9 PEG parser patch needed to backport the test added by GH-20486.
(cherry picked from commit a5d6aba)

Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants