Skip to content

bpo-38530: Clean exceptions if dir() fails when making suggestions for AttributeError #25408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2021
Merged

bpo-38530: Clean exceptions if dir() fails when making suggestions for AttributeError #25408

merged 3 commits into from
Apr 14, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 14, 2021 •
edited by bedevere-bot
Loading

vstinner
vstinner reviewed Apr 14, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I would prefer to clear the exception in the function calling _Py_Offer_Suggestions().

@pablogsal
Copy link
Member Author

Honestly, I would prefer to clear the exception in the function calling _Py_Offer_Suggestions().

Ok, we can do that

@pablogsal pablogsal requested a review from vstinner April 14, 2021 15:08
ammaraskar
ammaraskar reviewed Apr 14, 2021
View reviewed changes
vstinner
vstinner approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pablogsal pablogsal merged commit e07f4ab into python:master Apr 14, 2021
@pablogsal pablogsal deleted the bpo-38530 branch April 14, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammaraskar ammaraskar ammaraskar left review comments

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @vstinner @ammaraskar @the-knights-who-say-ni @bedevere-bot