Skip to content

bpo-38530: Properly extend UnboundLocalError from NameError #25444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2021
Merged

bpo-38530: Properly extend UnboundLocalError from NameError #25444

merged 1 commit into from
Apr 16, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 16, 2021 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested a review from isidentical April 16, 2021 15:12
isidentical
isidentical approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@isidentical isidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vstinner
vstinner reviewed Apr 16, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issubclass(UnboundLocalError, NameError) already returns True. What is the effect of this change?

vstinner
vstinner approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ah, this change is needed because NameError now defines its init, dealloc, traverse, etc. methods. Ok, I get it ;-)

@pablogsal pablogsal merged commit 3b82cae into python:master Apr 16, 2021
@pablogsal pablogsal deleted the bpo-38530-3 branch April 16, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@isidentical isidentical isidentical approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @vstinner @isidentical @the-knights-who-say-ni @bedevere-bot