bpo-45155 : Default arguments for int.to_bytes(length=1, byteorder=sys.byteorder)

[warsaw]

In the PEP 467 discussion, I proposed being able to use

>>> (65).to_bytes()
b'A'

IOW, adding default arguments for the length and byteorder arguments to int.to_bytes()

It occurs to me that this is (1) useful on its own merits; (2) easy to do. So I've done it.

https://bugs.python.org/issue45155

[rhettinger]

This is a nice improvement. Thanks.

[ericvsmith]

This all looks reasonable to me. But .format() instead of f-strings? What?!

[rhettinger]

The main docs need to be updated as well: https://docs.python.org/3/library/stdtypes.html?highlight=to_bytes#int.to_bytes

[warsaw]

This all looks reasonable to me. But .format() instead of f-strings? What?!

Ha! I knew you'd say that 😆
I wanted to minimally edit the line so it would fit within my editor line length. That looked like some Python 2.6 code to me!

The main docs need to be updated as well: https://docs.python.org/3/library/stdtypes.html?highlight=to_bytes#int.to_bytes

Yep, thanks @rhettinger ... coming up!

[rhettinger]

Also consider updating the default byteorder for int.from_bytes. The to/from round trip should be as symmetrical as possible.

[brandtbucher]

Beat me to it! I agree that int.from_bytes deserves the same treatment, too.

I also saw one possible improvement:

[encukou]

Please, for the sake of reproducible science (and other cases), don't add platform-dependent defaults.

[bedevere-bot]

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

[warsaw]

I have made the requested changes; please review again.

[bedevere-bot]

Thanks for making the requested changes!

@brandtbucher: please review the changes made to this pull request.

[brandtbucher]

Looks good! Just one RST nit:

[warsaw]

"big" by default.

[brandtbucher]

I think you missed some!

[bedevere-bot]

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

[warsaw]

Thanks for catching the ones I missed @brandtbucher

[warsaw]

I have made the requested changes; please review again.

[bedevere-bot]

Thanks for making the requested changes!

@brandtbucher: please review the changes made to this pull request.

[brandtbucher]

Sorry, I promise this is my last review!

Just realized that we can help AC give us a better __text_signature__ (for help, inspect, etc.). Other than that improvement, this looks good!

[brandtbucher]

(I think you need to re-run AC locally, too.)

[bedevere-bot]

@warsaw: Please replace # with GH- in the commit message next time. Thanks!