bpo-45464: Add a warning about subclassing built-in exceptions #28995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambv
reviewed
Oct 19, 2021
| @@ -66,6 +66,8 @@ In either case, the exception itself is always shown after any chained | |||
| exceptions so that the final line of the traceback always shows the last | |||
| exception that was raised. | |||
|
|
|||
| .. warning:: Creating a subclass that inherits from multiple exceptions may not | |||
There was a problem hiding this comment.
We generally avoid warning boxes on docs.python.org, instead opting for a more affirmative documentation style. See here: https://devguide.python.org/documenting/#affirmative-tone
There was a problem hiding this comment.
I still prefer the warning because I think this should have more visibility and he have done this in the past for exactly this reason. In any case, I am happy to take a suggestion on how to make this more affirmative while keeping it visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45464
Automerge-Triggered-By: GH:pablogsal