bpo-32732 Extra kwargs of log() are ignored by LoggerAdapter

[mcoolive]

• LoggerAdapter processes only extra kwargs given during its init. So extra kwargs, given to Logger#log are ignored when we configure a LoggerAdapter (same for: debug, info, warning etc).
• I expect extras are merged. More precisely, I expect local extra override the ones given in init.

https://bugs.python.org/issue32732

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

[matrixise]

Clean this code

extra = dict(extra_1, **kwargs.get('extra', {}))

Example:

Python 3.8.0a0 (heads/master:07a1892f82, Feb  1 2018, 07:58:09) 
[GCC 7.2.1 20170915 (Red Hat 7.2.1-2)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> extra_1 = None or {'firstname': 'Cyril'}
>>> kwargs = {'extra': {'lastname': 'Martin'}}
>>> extra = dict(extra_1, **kwargs.get('extra', {}))
>>> extra
{'firstname': 'Cyril', 'lastname': 'Martin'}
>>> 

[mcoolive]

It works.
I am a beginner in Python, so I don't know what is 'the pythonic way'. I don't understand why you dislike '{ **x, **y}'. But I found some criticisms about 'dict(x, **y)'

• https://stackoverflow.com/questions/38987/how-to-merge-two-dictionaries-in-a-single-expression
• https://mail.python.org/pipermail/python-dev/2010-April/099459.html

So should I really replace '{ **x, **y}' by 'dict(x, **y)' ?

[vsajip]

I am minded to close this pull request without merging, because the behaviour is not a bug - it works the way it does by design. It is generally better to just raise an issue to ensure that this really is an issue that needs resolving, otherwise the time you spend crafting a PR is wasted. This holds doubly true if you are a Python beginner.