Skip to content

gh-91498: socket: Add TCP_CONNECTION_INFO on macOS #69256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2022
Merged

gh-91498: socket: Add TCP_CONNECTION_INFO on macOS #69256

merged 2 commits into from
Apr 27, 2022

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Apr 10, 2022 •
edited by corona10
Loading

closes: #91498

JelleZijlstra
JelleZijlstra reviewed Apr 10, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be added to Doc/library/socket.rst, similar to the existing notes under https://docs.python.org/3.10/library/socket.html#socket.SOMAXCONN.

Misc/NEWS.d/next/Library/2022-04-10-08-39-44.bpo-69256.8oII92.rst Outdated
@@ -0,0 +1 @@
Adding ``TCP_CONNECTION_INFO`` macOs' option for the socketmodule
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Adding ``TCP_CONNECTION_INFO`` macOs' option for the socketmodule
Add the ``TCP_CONNECTION_INFO`` option (available on macOS) to :mod:`socket`.

@JelleZijlstra
Copy link
Member

Also, this should have an associated issue. Your NEWS entry refers to https://bugs.python.org/issue69256 which doesn't exist. We're in the process of moving to GitHub right now; once that's done (in a few hours I believe) you should make an associated GitHub issue.

@devnexen devnexen force-pushed the tcp_connection_info_macos branch from 036540c to 07e935f Compare April 13, 2022 08:19
@devnexen devnexen changed the title socketmodule: add macOs's TCP_CONNECTION_INFO socket option. gh-91498: socketmodule add macOs's TCP_CONNECTION_INFO socket option. Apr 13, 2022
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 14, 2022
Closed
@methane methane changed the title gh-91498: socketmodule add macOs's TCP_CONNECTION_INFO socket option. gh-91498: socket: Add TCP_CONNECTION_INFO on macOS Apr 14, 2022
@devnexen devnexen force-pushed the tcp_connection_info_macos branch from 07e935f to ae87fea Compare April 26, 2022 18:33
@JelleZijlstra JelleZijlstra self-assigned this Apr 26, 2022
@JelleZijlstra JelleZijlstra self-requested a review April 26, 2022 18:34
JelleZijlstra
JelleZijlstra approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled on my Mac and it's indeed present

>>> socket.TCP_CONNECTION_INFO
262

@JelleZijlstra JelleZijlstra merged commit ad9f817 into python:main Apr 27, 2022
JelleZijlstra added a commit to python/typeshed that referenced this pull request Apr 30, 2022
@JelleZijlstra
Add socket.TCP_CONNECTION_INFO
b12e7ba 
python/cpython#69256
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 30, 2022
Merged
AlexWaygood pushed a commit to python/typeshed that referenced this pull request Apr 30, 2022
@JelleZijlstra
Add socket.TCP_CONNECTION_INFO (#7755)
7e7562b 
python/cpython#69256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

socket: Add TCP_CONNECTION_INFO
5 participants
@devnexen @JelleZijlstra @methane @the-knights-who-say-ni @bedevere-bot