Skip to content

bpo-5978: Document that profiling needs cmd/function to return #7938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2018

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Jun 26, 2018

Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the patch

@tiran tiran merged commit 937fb55 into python:master Jul 28, 2018
@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR, and @tiran for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @andresdelfino and @tiran, I had trouble checking out the 3.6 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 937fb55d35373fd2701078251840b6be0465a6e1 3.6

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2018
…nGH-7938)

<!-- issue-number: bpo-5978 -->
https://bugs.python.org/issue5978
<!-- /issue-number -->
(cherry picked from commit 937fb55)

Co-authored-by: Andrés Delfino <[email protected]>
@bedevere-bot
Copy link

GH-8512 is a backport of this pull request to the 3.7 branch.

andresdelfino added a commit to andresdelfino/cpython that referenced this pull request Jul 28, 2018
…ythonGH-7938)

<!-- issue-number: bpo-5978 -->
https://bugs.python.org/issue5978
<!-- /issue-number -->
(cherry picked from commit 937fb55)

Co-authored-by: Andrés Delfino <[email protected]>
@bedevere-bot
Copy link

GH-8515 is a backport of this pull request to the 3.6 branch.

@andresdelfino andresdelfino deleted the bpo-5978 branch July 28, 2018 10:37
miss-islington added a commit that referenced this pull request Jul 28, 2018
<!-- issue-number: bpo-5978 -->
https://bugs.python.org/issue5978
<!-- /issue-number -->
(cherry picked from commit 937fb55)

Co-authored-by: Andrés Delfino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants