Skip to content

[3.10] gh-92049: Forbid pickling constants re._constants.SUCCESS etc (GH-92070) #92073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

serhiy-storchaka
Copy link
Member

Previously, pickling did not fail, but the result could not be unpickled.
(cherry picked from commit 6d0d547)

…S etc (pythonGH-92070)

Previously, pickling did not fail, but the result could not be unpickled..
(cherry picked from commit 6d0d547)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting core review labels Apr 30, 2022
@serhiy-storchaka serhiy-storchaka added the 3.9 only security fixes label Apr 30, 2022
@serhiy-storchaka serhiy-storchaka merged commit e8ff3c9 into python:3.10 Apr 30, 2022
@serhiy-storchaka serhiy-storchaka deleted the backport-6d0d547-3.10 branch April 30, 2022 12:33
@serhiy-storchaka serhiy-storchaka added needs backport to 3.9 only security fixes and removed 3.9 only security fixes labels May 1, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e8ff3c92f69b475aa20ba7c08efccbc329f9b42e 3.9

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 1, 2022
…SUCCESS etc (pythonGH-92070) (pythonGH-92073)

Previously, pickling did not fail, but the result could not be unpickled.
(cherry picked from commit 6d0d547)
(cherry picked from commit e8ff3c9)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 1, 2022
@bedevere-bot
Copy link

GH-92102 is a backport of this pull request to the 3.9 branch.

serhiy-storchaka added a commit that referenced this pull request May 1, 2022
…H-92070) (GH-92073) (GH-92102)

Previously, pickling did not fail, but the result could not be unpickled.
(cherry picked from commit 6d0d547)
(cherry picked from commit e8ff3c9)
@serhiy-storchaka serhiy-storchaka removed their assignment May 21, 2022
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
… etc (pythonGH-92070) (pythonGH-92073) (pythonGH-92102)

Previously, pickling did not fail, but the result could not be unpickled.
(cherry picked from commit 6d0d547)
(cherry picked from commit e8ff3c9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants