bpo-34980: P/Invoke QueryFullProcessImageName to get process' name #9901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow the 32-bit MSBuild to access 64-bit processes names.
|
Thanks for the PR @jkloth. I've added the skip news label so the Windows core devs can see that there are no failing tests 👍 |
zooba
approved these changes
Oct 22, 2018
PCbuild/pyproject.props
Outdated
| try { | ||
| int pathLength = 32768; | ||
| StringBuilder pathBuilder = new StringBuilder(pathLength); | ||
| QueryFullProcessImageName(p.Handle, 0, pathBuilder, ref pathLength); |
There was a problem hiding this comment.
Weird indentation going on here, and would be nice to just continue here if it fails.
There was a problem hiding this comment.
Oops, some tabs crept in.
I'm unsure to what the continue you refer to. The return at the end is due to the change from type="Fragment" to type="Method".
There was a problem hiding this comment.
If QueryFullProcessImageName returns false, we don't want to bother with anything else after it.
|
GH-10055 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 23, 2018
…ythonGH-9901) (cherry picked from commit fa53294) Co-authored-by: Jeremy Kloth <[email protected]>
|
GH-10056 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 23, 2018
…ythonGH-9901) (cherry picked from commit fa53294) Co-authored-by: Jeremy Kloth <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 23, 2018
…H-9901) (cherry picked from commit fa53294) Co-authored-by: Jeremy Kloth <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 23, 2018
…H-9901) (cherry picked from commit fa53294) Co-authored-by: Jeremy Kloth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34980