Skip to content

Fixes to unittest stubs #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2017
Merged

Fixes to unittest stubs #1024

merged 2 commits into from
Mar 18, 2017

Conversation

JukkaL
Copy link
Contributor

@JukkaL JukkaL commented Mar 18, 2017

These are needed for a mypy PR that I'm preparing.

@@ -189,7 +189,7 @@ class FunctionTestCase(TestCase):
description: Optional[str] = ...) -> None: ...

class _AssertRaisesContext:
exception = ... # type: Exception
exception = ... # type: Any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What else can it be?

Copy link
Contributor

@ddfisher ddfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making things more specific. LGTM!

@ambv ambv merged commit f296b37 into master Mar 18, 2017
@gvanrossum gvanrossum deleted the unittest-fixes branch March 22, 2017 14:23
hswong3i pushed a commit to alvistack/python-typeshed that referenced this pull request May 25, 2025
…ersion (python#1024)

As pointed out in python#1023, there is no risk of incompatibility, since the
requires-python field will prevent installation on older Python versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants