Cast query_cache value when using URL configuration
#53491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
reviewed
Oct 30, 2024
Comment on lines
85
to
92
| case value = configuration_hash[:query_cache] | ||
| when /\A\d+\z/ | ||
| value.to_i | ||
| when "false" | ||
| false | ||
| else | ||
| value | ||
| end |
There was a problem hiding this comment.
I think this should be in the subclass, UrlConfig, as it doesn't make sense to do casting when provided a hash from Ruby.
There was a problem hiding this comment.
Whoops, yeah forgot we talked about this. Fixed in 6302519.
c26781d to
6302519
Compare
byroot
reviewed
Oct 30, 2024
| @@ -57,6 +57,17 @@ def initialize(env_name, name, url, configuration_hash = {}) | |||
| @configuration_hash.freeze | |||
| end | |||
|
|
|||
| def query_cache # :nodoc: | |||
| case value = configuration_hash[:query_cache] | |||
There was a problem hiding this comment.
I think we might want to do this in initialize so that we don't redo it on every access.
There was a problem hiding this comment.
Ok, I didn't realize that was already happening for "false". Added 15606ec.
There was a problem hiding this comment.
Whoops fixed tests in af9b0f2
6302519 to
15606ec
Compare
15606ec to
af9b0f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
DATABASE_URL, you cannot adjust the max size of the query_cache using the parameter. Since it remains as the string"42"it will result in not setting a max size:rails/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb
Lines 122 to 129 in 1869a5a
cc @byroot