…#6251)

* fix: finalize behaves well with useDeprecatedSynchronousErrorHandling

Adds tests and ensures a few more scenarios that were hit in Google because they use the deprecated synchronous error handling.

fixes #6250

* refactor: Move deprecated junk to its own method

Just for readability. The deprecated stuff is a hot mess, and this shows what we get to delete in version 8 more cleanly.

* refactor: Add more comments

* test: Add more tests around gross mode and finalize

)

Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…6252)

…ameter from all unit tests (#6257)

* refactor: refactor unit tests to include Mocha.Done type for done parameter

* refactor: remove type annotations MochaDone & Mocha.Done for done parameter from all unit tests

* chore: align marbles within literal

Co-authored-by: Nitin Malave <[email protected]>
Co-authored-by: Nicholas Jamieson <[email protected]>

* docs: Document differences between 6.x and 7.x golden files

Adds a document outlining all discovered differences between version 6 and version 7 as they can be found while diffing the api_guardian snapshots. This document should be an exhaustive list of changes and we should modify it ongoing if we think of anything else that has changed that cannot be found here yet.

* chore: Address comments

* docs(release): prepare docs for version 7 release

* docs(index): support blm movement

Co-authored-by: Jan-Niklas Wortmann <[email protected]>
Co-authored-by: Jan-Niklas Wortmann <[email protected]>

#6272)

Fixes a should-be-obvious issue where we were making sure `dest` was `undefined`, then trying to set a property on it.

fixes #6271

* docs: add buffer breaking change

* docs: add ReplaySubject breaking change

* feat: add config object to connectable

* chore: update api_guardian

* chore: typo

BREAKING CHANGE: Our very new api, `connectable`, now takes a configuration object instead of just the `Subject` instance. This was necessary to make sure it covered all use cases for what we were trying to replace in the deprecated multicasting operators. Apologies for the late-in-the-game change, but we know it's not widely used yet (it's new in v7), and we want to get it right.

Co-authored-by: Ben Lesh <[email protected]>

* chore: remove unused $$iterator symbol

* chore: update some renamed deprecations

* chore: update some internal deprecations

* chore: update scheduler deprecations

* chore: update the xWith-related deprecations

* chore: update empty and never deprecations

* chore: update config deprecations

* chore: update timeoutWith deprecations

* chore: update generate deprecations

* chore: update TimeInterval deprecation

* chore: update Observable and tap deprecations

* chore: update pluck deprecation

* chore: update partition deprecation

* chore: remove sampleTime deprecation

Neither auditTime nor throttleTime are deprecated, so...

* chore: update resultSelector deprecations

* chore: update mergeMapTo deprecation

* chore: add backticks

* chore: update scheduler parameter deprecations

* chore: update pairs deprecations

* chore: update scheduler parameter deprecations

* chore: update delayWhen deprecations

* chore: update timer deprecation

* chore: update api_guardian

* chore: update throwError deprecations

* chore: remove delayWhen dtslint deprecation test

* chore: use API type in defer docs

* chore: update Notification deprecations

* chore: remove materialize deprecation

* docs: add multicasting deprecations doc

* chore: add colon after details

* chore: update multicasting deprecations

* docs: use upcoming connectable API changes

* chore: use upcoming connectable API changes

* chore: update ajax deprecations

* chore: update websocked deprecation

* chore: update uninferrable type param deprecations

* chore: update fromEvent deprecations

* chore: update rest-params deprecations

…t tests and .ts file (#6261)

* refactor: refactor throwError operator to use factory function in unit tests and .ts file

* test: add unit test for throwError factory support

Co-authored-by: Nitin Malave <[email protected]>