Skip to content

Improve documentation for <select> controlled component #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nupurgrover opened this issue Jan 14, 2018 · 3 comments
Open

Improve documentation for <select> controlled component #524

nupurgrover opened this issue Jan 14, 2018 · 3 comments

Comments

@nupurgrover
Copy link

nupurgrover commented Jan 14, 2018

In the React documentation for forms, there is only a footnote on using the controlled component with the multiple attribute. I recently spent some time getting it to work for my use case and I feel having better documentation would have sped things up. My use case involved populating the <option> elements from JSON data being returned from the server, for a select component with the multiple attribute. I am happy to contribute the documentation and raise a PR :)

@alexkrolick
Copy link
Collaborator

A PR would be very welcome!

@nupurgrover
Copy link
Author

Okay, I will submit one in the next couple of days!

BetterZxx pushed a commit to BetterZxx/react.dev that referenced this issue Mar 21, 2023
原文是"close over",有"掩盖"的意思,例子将直接暴露的state改为了只暴露需要的state,因此翻译为"控制暴露程度"更便于理解
@rickhanlonii
Copy link
Member

The new place this exists in the docs is here: https://react.dev/reference/react-dom/components/select#enabling-multiple-selection

I think we could add a new Usage example for "Controlling a select box with multiple options"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants