Do not evaluate dependent immediate invocations #13700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We deferred the evaluation of dependent immediate invocations in https://reviews.llvm.org/D119375 until instantiation. We should also not consider them referenced from a non-consteval context. Fixes: llvm/llvm-project#55601 ``` template<typename T> class Bar { consteval static T x() { return 5; } public: Bar() : a(x()) {} private: int a; }; Bar<int> g(); ``` Is now accepted by clang. Previously it errored with: `cannot take address of consteval function 'x' outside of an immediate invocation Bar() : a(x()) {}` Differential Revision: https://reviews.llvm.org/D132031 --- Fixes root-project#13698, a problem with the new C++ headers from the new macOS SDK.
|
@phsft-bot build also on mac13/cxx20, mac13arm/cxx20 |
|
Starting build on |
vgvassilev
approved these changes
Sep 21, 2023
|
Build failed on mac13arm/cxx20. Warnings:
And 891 more Failing tests:
And 61 more |
dpiparo
approved these changes
Sep 21, 2023
|
The numerous failures are fixed by this PR #13696 |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests:
|
|
Build failed on mac13/cxx20. Warnings:
And 897 more Failing tests:
And 61 more |
|
Unbelievable @hahnjo - congratulations! |
|
FWIW there were build problems in the incremental GitHub Actions CI (because I forgot to set the right label); they are gone in a clean build triggered by the merge to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We deferred the evaluation of dependent immediate invocations in https://reviews.llvm.org/D119375 until instantiation. We should also not consider them referenced from a non-consteval context.
Fixes: llvm/llvm-project#55601
Is now accepted by clang. Previously it errored with:
cannot take address of consteval function 'x' outside of an immediate invocation Bar() : a(x()) {}Differential Revision: https://reviews.llvm.org/D132031
Fixes #13698, a problem with the new C++ headers from the new macOS SDK.