Merge pull request #14192 from koic/fix_false_negatives_for_layout_space_before_brackets

Fix false negatives for `Layout/SpaceBeforeBrackets`

Author: koic

changelog/fix_false_negatives_for_layout_space_before_brackets.md

@@ -0,0 +1 @@
+* [#14192](https://github.com/rubocop/rubocop/pull/14192): Fix negatives for `Layout/SpaceBeforeBrackets` when using space between method argument parentheses and left bracket. ([@koic][])

lib/rubocop/cop/layout/space_before_brackets.rb

@@ -26,7 +26,6 @@ def on_send(node)
           selector_begin_pos = node.loc.selector.begin_pos
           return if receiver_end_pos >= selector_begin_pos
           return if dot_before_brackets?(node, receiver_end_pos, selector_begin_pos)
-          return if !reference_variable_with_brackets?(node) && !node.method?(:[]=)
 
           range = range_between(receiver_end_pos, selector_begin_pos)
 
@@ -42,10 +41,6 @@ def dot_before_brackets?(node, receiver_end_pos, selector_begin_pos)
 
           dot.begin_pos == receiver_end_pos && dot.end_pos == selector_begin_pos
         end
-
-        def reference_variable_with_brackets?(node)
-          node.receiver&.variable? && node.method?(:[]) && node.arguments.size == 1
-        end
       end
     end
   end

lib/rubocop/cop/style/command_literal.rb

@@ -173,7 +173,7 @@ def default_delimiter
         end
 
         def preferred_delimiters_config
-          config.for_cop('Style/PercentLiteralDelimiters') ['PreferredDelimiters']
+          config.for_cop('Style/PercentLiteralDelimiters')['PreferredDelimiters']
         end
       end
     end

lib/rubocop/cop/style/regexp_literal.rb

@@ -155,7 +155,7 @@ def slash_literal?(node)
         end
 
         def preferred_delimiters
-          config.for_cop('Style/PercentLiteralDelimiters') ['PreferredDelimiters']['%r'].chars
+          config.for_cop('Style/PercentLiteralDelimiters')['PreferredDelimiters']['%r'].chars
         end
 
         def allowed_omit_parentheses_with_percent_r_literal?(node)

spec/rubocop/cop/layout/space_before_brackets_spec.rb

@@ -48,6 +48,17 @@
       RUBY
     end
 
+    it 'registers an offense and corrects when using space between method argument parentheses and left bracket' do
+      expect_offense(<<~RUBY)
+        collection.call(arg) [index_or_key]
+                            ^ Remove the space before the opening brackets.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        collection.call(arg)[index_or_key]
+      RUBY
+    end
+
     it 'does not register an offense when using space between method call and left brackets' do
       expect_no_offenses(<<~RUBY)
         do_something [item_of_array_literal]