Skip to content

Actors - Improving documentation; other improvements #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jun 2, 2015
Merged

Actors - Improving documentation; other improvements #180

merged 20 commits into from
Jun 2, 2015

Conversation

pitr-ch
Copy link
Member

@pitr-ch pitr-ch commented Oct 29, 2014

fixes #155

@pitr-ch
All messages should have same priority
0969f9c 
It's now possible to send actor << job1 << job2 <<:terminate! and be sure that
both jobs are processed first.
@pitr-ch
Improving documentation
b898a47
@pitr-ch
Add IO example
810a591
@pitr-ch
Add AbstractContext#default_executor
08835fe 
to be able to override executor class wide
@pitr-ch
Print also object_id in Reference to_s
3c18951
@pitr-ch
Improve actor events
469eaa3 
Events can be private and public, so far only difference is that Linking will
pass to linked actors only public messages. Adding private :restarting and
:resetting events which are send before the actor restarts or resets allowing
to add callbacks to cleanup current child actors.
@pitr-ch
Adding example of supervision-tree
741d3ac 
For now built manually.
@pitr-ch pitr-ch changed the title Actors - All messages should have same priority; Improving documentation Actors - Improving documentation; other improvements Nov 8, 2014
@jdantonio
Copy link
Member

@pitr-ch Is this ready to be merged? If possible I would like to release 0.7.1 this evening. RubyConf starts tomorrow and both @chrisseaton and I (possibly others) will be in attendance. We can wait if this work isn't ready.

@pitr-ch
Copy link
Member Author

pitr-ch commented Nov 16, 2014

@jdantonio I would move it to 0.7.2 just to be safe. I did not have time to test it more and finish the doc.

@jdantonio
Copy link
Member

Sounds good. Although it looks like I may not be able to release 0.7.1 like I hoped. Due to a failed upgrade to OS X Yosemite I had to restore my MacBook from backup. I don't include VMs in my backup so I just realized that all my VMs are gone--including the ones I use to pre-compile the gem builds. Based on the download speeds I have in my hotel it's going to take a very long time to build new VMs. :-(

@pitr-ch
Merge remote-tracking branch 'upstream/master' into actress
ff37c93 
* upstream/master: (14 commits)
  Added another dataflow example from the wiki.
  ...
@jdantonio
Copy link
Member

@pitr-ch As you can tell, I wasn't able to create a new release while in San Diego. So unless someone needs an update immediately, we can wait until this is done for the next release. That will give me some time to work on some of the open issues.

@pitr-ch
Copy link
Member Author

pitr-ch commented Nov 26, 2014

Thanks, I'll try to finish it but it may take about 2 weeks :/

@pitr-ch
Copy link
Member Author

pitr-ch commented Dec 4, 2014

@jdantonio let's not wait on this, blocking other bug fixes. Feel free to release if you want to. We can do 7.0.2 or it'll go to 0.8.

@jdantonio
Copy link
Member

0.7.1 has been released.

pitr-ch added 3 commits January 1, 2015 16:00
@pitr-ch
Merge remote-tracking branch 'upstream/master' into actress
6a42240 
* upstream/master: (52 commits)
  Add test to verify that TimerSet#post returns true
  ...
@pitr-ch
Actor::Reference doc update
595f7cd
@pitr-ch
Supervised and linked by default
1b96989 
Pass spawn options to behaviours
@pitr-ch pitr-ch modified the milestone: 0.8.0 Release Jan 1, 2015
@pitr-ch
Remove supervised behavior
6ed9e81 
Linking is enough,
Supervised was just making things complicated.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.29%) when pulling 6ed9e81 on actress into 8ef62bb on master.

@pitr-ch
Copy link
Member Author

pitr-ch commented Jan 16, 2015

I'll probably show few new thinks I am cooking in actors on FOSDEM but it'll not make it to 0.8 :(

@jdantonio
Copy link
Member

No hurry. I just want to make sure I don't push releases without giving you the opportunity to merge.

@pitr-ch pitr-ch modified the milestones: 0.9.0 Release, 0.8.0 Release Jan 16, 2015
@pitr-ch
Copy link
Member Author

pitr-ch commented Jan 16, 2015

@jdantonio I hope I'll update this PR after this weekend but still it won't be ready for merge unless we mark it experimental (probably not a good idea). This may interest you though, after looking more into Akka and Erlang supervision approach I am moving more towards Erlang's approach so next version will have Erlang's behavior (with minor changes since this is OOP) and its Supervisor implemented. It would be great if you could review it after it's ready since you have experience with Erlang.

@jdantonio
Copy link
Member

Absolutely! I'm looking forward to seeing what you put together.

@Papipo
Copy link

Papipo commented Jan 16, 2015

@pitr-ch are the interfaces going to change?

@pitr-ch
Copy link
Member Author

pitr-ch commented Jan 17, 2015

@Papipo Unfortunately there will be some changes, nothing fundamental though.

@jdantonio jdantonio modified the milestones: 1.0.0 Release, 0.9.0 Release Mar 1, 2015
@pitr-ch pitr-ch self-assigned this Mar 12, 2015
@jdantonio
Copy link
Member

@pitr-ch Is work on this PR still ongoing, or has it been superseded by other PRs?

@pitr-ch
Copy link
Member Author

pitr-ch commented Apr 24, 2015

Ongoing, This will be merged to #274 and merged with it, I'll close this one then.

@pitr-ch pitr-ch mentioned this pull request Apr 24, 2015
Merged
5 tasks
@pitr-ch
Merge branch 'synchronization' into actress
3bd2cf1 
* synchronization: (279 commits)
  Edge - Future tweaks
  ...
@pitr-ch pitr-ch modified the milestones: 0.9.0 Release, 1.0.0 Release May 24, 2015
@pitr-ch pitr-ch added the enhancement Adding features, adding tests, improving documentation. label May 24, 2015
@pitr-ch pitr-ch force-pushed the actress branch 2 times, most recently from f42eb43 to 8aad4d2 Compare May 24, 2015 12:28
@pitr-ch
Copy link
Member Author

pitr-ch commented May 24, 2015

This is updated and will be merged after #296.

pitr-ch added 3 commits May 31, 2015 10:31
@pitr-ch
Merge branch 'master' into actress
1dc2ff8 
* master: (41 commits)
  Attempt to improve Dereferenceable shared specs.
  ...
@pitr-ch
Remove redundant logger configuration
c94f03b
@pitr-ch
Stabilize RubyThreadPool specs
0cead11
@pitr-ch
Copy link
Member Author

pitr-ch commented May 31, 2015

Ready for merge.

jdantonio added a commit that referenced this pull request Jun 2, 2015
@jdantonio
Merge pull request #180 from ruby-concurrency/actress
04863fd 
Actors - Improving documentation; other improvements
@jdantonio jdantonio merged commit 04863fd into master Jun 2, 2015
@jdantonio jdantonio deleted the actress branch November 9, 2015 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pitr-ch pitr-ch

Labels
enhancement Adding features, adding tests, improving documentation.
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Documentation on Actors is misleading
4 participants
@pitr-ch @jdantonio @coveralls @Papipo