Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #216 and adds a UT for it. I also think I spotted a possible race condition (where we peek from a queue, do something with that task, and then pop from the queue, without guarding against the possibility that the head of the queue has changed since we peeked).
I checked that:
rake spec SPEC=spec/concurrent/executor/timer_set_spec.rb
passesrake spec SPEC=spec/concurrent/executor/timer_set_spec.rb
fails without my commit 894ac23