Rename plugin/disable_ternary to plugin/disable_auto_ternary

Author: kddnewton

README.md

@@ -658,7 +658,7 @@ To register plugins, define a file somewhere in your load path named `syntax_tre
 
 * `plugin/single_quotes` - This will change all of your string literals to use single quotes instead of the default double quotes.
 * `plugin/trailing_comma` - This will put trailing commas into multiline array literals, hash literals, and method calls that can support trailing commas.
-* `plugin/disable_ternary` - This will prevent the automatic conversion of `if ... else` to ternary expressions.
+* `plugin/disable_auto_ternary` - This will prevent the automatic conversion of `if ... else` to ternary expressions.
 
 If you're using Syntax Tree as a library, you can require those files directly or manually pass those options to the formatter initializer through the `SyntaxTree::Formatter::Options` class.
 

lib/syntax_tree/formatter.rb

@@ -23,13 +23,13 @@ def initialize(version)
     class Options
       attr_reader :quote,
                   :trailing_comma,
-                  :disable_ternary,
+                  :disable_auto_ternary,
                   :target_ruby_version
 
       def initialize(
         quote: :default,
         trailing_comma: :default,
-        disable_ternary: :default,
+        disable_auto_ternary: :default,
         target_ruby_version: :default
       )
         @quote =
@@ -54,15 +54,15 @@ def initialize(
             trailing_comma
           end
 
-        @disable_ternary =
-          if disable_ternary == :default
+        @disable_auto_ternary =
+          if disable_auto_ternary == :default
             # We ship with a disable ternary plugin that will define this
             # constant. That constant is responsible for determining the default
             # disable ternary value. If it's defined, then we default to true.
             # Otherwise we default to false.
             defined?(DISABLE_TERNARY)
           else
-            disable_ternary
+            disable_auto_ternary
           end
 
         @target_ruby_version =
@@ -84,9 +84,13 @@ def initialize(
 
     # These options are overridden in plugins to we need to make sure they are
     # available here.
-    attr_reader :quote, :trailing_comma, :disable_ternary, :target_ruby_version
+    attr_reader :quote,
+                :trailing_comma,
+                :disable_auto_ternary,
+                :target_ruby_version
+
     alias trailing_comma? trailing_comma
-    alias disable_ternary? disable_ternary
+    alias disable_auto_ternary? disable_auto_ternary
 
     def initialize(source, *args, options: Options.new)
       super(*args)
@@ -97,7 +101,7 @@ def initialize(source, *args, options: Options.new)
       # Memoizing these values to make access faster.
       @quote = options.quote
       @trailing_comma = options.trailing_comma
-      @disable_ternary = options.disable_ternary
+      @disable_auto_ternary = options.disable_auto_ternary
       @target_ruby_version = options.target_ruby_version
     end
 

lib/syntax_tree/node.rb

@@ -6139,8 +6139,7 @@ def self.call(parent)
   module Ternaryable
     class << self
       def call(q, node)
-        return false if ENV["STREE_FAST_FORMAT"]
-        return false if q.disable_ternary?
+        return false if ENV["STREE_FAST_FORMAT"] || q.disable_auto_ternary?
 
         # If this is a conditional inside of a parentheses as the only content,
         # then we don't want to transform it into a ternary. Presumably the user

test/plugin/disable_ternary_test.rb

@@ -21,7 +21,7 @@ def test_short_ternary_unchanged
     private
 
     def assert_format(expected, source = expected)
-      options = Formatter::Options.new(disable_ternary: true)
+      options = Formatter::Options.new(disable_auto_ternary: true)
       formatter = Formatter.new(source, [], options: options)
       SyntaxTree.parse(source).format(formatter)