Bug formating code, possibly?

[stoivo]

I think I have found a bug. I think this code should work.

require 'bundler/inline'

gemfile do
  source 'https://rubygems.org'
  gem 'syntax_tree', '5.3.0'
end

require "syntax_tree"

source = <<~RUBY
with_options bookkeeping_account_number: 12 do
  validates :bookkeeping_number
end
RUBY

program = SyntaxTree.parse(source)
program => { statements: { body: [binary] } }

formatter = SyntaxTree::Formatter.new(source, [])
binary.format(formatter)

formatter.flush
formatter.output.join

right now I get

untitled2.rb:26: warning: One-line pattern matching is experimental, and the behavior may change in future versions of Ruby!                                                                                                                                                                                                               
/Users/simon/.asdf/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/syntax_tree-5.3.0/lib/syntax_tree/node.rb:4374:in `forced_do_end_bounds?': undefined method `call' for nil:NilClass (NoMethodError)                                                                                                                                        
        from /Users/simon/.asdf/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/syntax_tree-5.3.0/lib/syntax_tree/node.rb:4308:in `format'                                                                                                                                                                                                    
        from /Users/simon/.asdf/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/syntax_tree-5.3.0/lib/syntax_tree/formatter.rb:168:in `format'                                                                                                                                                                                                
        from /Users/simon/.asdf/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/syntax_tree-5.3.0/lib/syntax_tree/node.rb:3434:in `format'                                                                                                                                                                                                    
        from untitled2.rb:29:in `<main>'   

[kddnewton]

Yeah, generally we don't really test formatting inner nodes of the tree, just from the top down. But I can see this use case, so it'll be fixed by #300.

[stoivo]

Just so you know use it to see if you changed any assosiasions on any of our models. If you did it would require us to update some doc, sometimes. So I find all the calls to belongs_to, has_one or has_many and copy out just those calles like this.

class AssosiationVisitor < SyntaxTree::Visitor
  attr_reader :assosiations

  def initialize
    @assosiations = []
  end

  visit_method def visit_command(node)
    if ASSOSIATION_RELATIONS.member?(node.message.value)
      formatter = SyntaxTree::Formatter.new(node, [])
      node.format(formatter)

      formatter.flush
      @assosiations.push(formatter.output.join)
    end

    super
  end
end

def find_assisiations(source)
  visitor = AssosiationVisitor.new
  visitor.visit(SyntaxTree.parse(source))
  visitor.assosiations
end

[kddnewton]

Nice that's cool!

A small thing, you can move a couple of things around in there and it might be a little more ergonomic.

class AssosiationVisitor < SyntaxTree::Visitor
  attr_reader :assosiations

  def initialize
    @assosiations = []
  end

  visit_method def visit_command(node)
    if ASSOSIATION_RELATIONS.member?(node.message.value)
      formatter = SyntaxTree::Formatter.new(node, [])
      node.format(formatter)

      formatter.flush
      @assosiations.push(formatter.output.join)
    end

    super
  end

  def visit_program(node)
    assosiations
  end
end

def find_assisiations(source)
  SyntaxTree.parse(source).accept(AssosiationVisitor.new)
end

[stoivo]

It should be ... right?

  def visit_program(node)
    super
    assosiations
  end

[kddnewton]

Ahh yeah, there should be a super in there, whoops