Add arity to Params, DefNode and BlockNode #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddnewton
requested changes
Jan 18, 2023
aef211c to
b47eb46
Compare
|
Once this one goes in, I'll rebase #257 and apply the same comments about memoization, attr readers and infinity to match this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
aritymethod toDefNodeandBlockNodethroughParams. The method returns a range where the lower bound is minimum and the upper bound is the maximum number of arguments that may be used to invoke that block/method.Question: should we add the same to
Lambda? We have no immediate use case for it, but maybe it makes sense for completion sake.