Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/backtrace-rs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.3.25
Choose a base ref
...
head repository: rust-lang/backtrace-rs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.3.27
Choose a head ref
  • 19 commits
  • 28 files changed
  • 1 contributor

Commits on May 25, 2019

  1. Compat with 1.25.0

    alexcrichton committed May 25, 2019
    Configuration menu
    Copy the full SHA
    aedcae4 View commit details
    Browse the repository at this point in the history
  2. Bump to 0.3.26

    alexcrichton committed May 25, 2019
    Configuration menu
    Copy the full SHA
    169c789 View commit details
    Browse the repository at this point in the history
  3. Revert "Compat with 1.25.0"

    This reverts commit 6e45341.
    alexcrichton committed May 25, 2019
    Configuration menu
    Copy the full SHA
    6c580b8 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2019

  1. Configuration menu
    Copy the full SHA
    35cd8de View commit details
    Browse the repository at this point in the history
  2. Fix the skip_inner_frames test

    Not all platforms support precisely locating the `symbol_address` for a
    frame which means that this test only works on platforms which do.
    alexcrichton committed May 28, 2019
    Configuration menu
    Copy the full SHA
    35ec005 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. Configuration menu
    Copy the full SHA
    dd2ac2c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f573ae9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f9c0985 View commit details
    Browse the repository at this point in the history
  4. Skip skip_inner_frames on OSX

    Looks like finding the enclosing function either isn't fully implemented
    or is buggy or something like that. In any case it's not working well
    enough that we can test it.
    alexcrichton committed May 29, 2019
    Configuration menu
    Copy the full SHA
    77cf78d View commit details
    Browse the repository at this point in the history
  5. Skip skip_inner_frames on ARM

    Finding the enclosing function doesn't work there either
    alexcrichton committed May 29, 2019
    Configuration menu
    Copy the full SHA
    c7172b6 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2019

  1. Don't adjust the IP with libunwind

    This was first introduced with the very first implementation of
    symbolication way back when in
    rust-lang/rust@bdd31b3, but nowadays
    it's not entirely clear that this is still necessary. In any case it's
    best to have the adjustment done in symbolication code rather than the
    return value of `Frame::ip`, so switch to returning an unadjusted
    instruction address.
    
    If this causes issues we can always have some offsets later on in the
    return values!
    alexcrichton committed May 30, 2019
    Configuration menu
    Copy the full SHA
    901f1f6 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #192 from rust-lang/maybe-not-adjust

    Don't adjust the IP with libunwind
    alexcrichton authored May 30, 2019
    Configuration menu
    Copy the full SHA
    17cb244 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2019

  1. Move aux crates in a crates directory

    Just an internal refactoring before more are added.
    alexcrichton committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    f15a3e9 View commit details
    Browse the repository at this point in the history
  2. Add a test that without debuginfo symbols still resolve

    Almost all platforms should still have some degree of symbolication
    without debug symbols being present (aka the dynamic symbol table and
    such), so add a test asserting that symbols do indeed come out in these
    scenarios.
    
    This test will likely need to be blacklisted for platforms over time,
    but that's ok.
    alexcrichton committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    0f7946f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    577e602 View commit details
    Browse the repository at this point in the history
  4. Add a test that without debuginfo symbols still resolve

    Almost all platforms should still have some degree of symbolication
    without debug symbols being present (aka the dynamic symbol table and
    such), so add a test asserting that symbols do indeed come out in these
    scenarios.
    
    This test will likely need to be blacklisted for platforms over time,
    but that's ok.
    alexcrichton committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    c15b7a3 View commit details
    Browse the repository at this point in the history
  5. Fall back to dladdr on Unix in more places

    Currently CoreSymbolication will fall back to `dladdr` but this also
    applies the same logic to the `libbacktrace` symbolication strategy
    since libbacktrace (especially on OSX) can't always get symbol name
    information. Instead these platforms will all fall back to `dladdr` if
    no symbol information is learned from libbacktrace.
    
    This involved some refactoring internally since all invocations calling
    the `dladdr` function are now shared instead of having three separate
    ones throughout.
    alexcrichton committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    861faf1 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #196 from rust-lang/work-without-debuginfo

    Fall back to `dladdr` on Unix in more places
    alexcrichton authored Jun 3, 2019
    Configuration menu
    Copy the full SHA
    21f4d73 View commit details
    Browse the repository at this point in the history
  7. Bump to 0.3.27

    alexcrichton committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    7b8f697 View commit details
    Browse the repository at this point in the history
Loading