-
Notifications
You must be signed in to change notification settings - Fork 264
Comparing changes
Open a pull request
base repository: rust-lang/backtrace-rs
base: 0.3.25
head repository: rust-lang/backtrace-rs
compare: 0.3.27
- 19 commits
- 28 files changed
- 1 contributor
Commits on May 25, 2019
-
Configuration menu - View commit details
-
Copy full SHA for aedcae4 - Browse repository at this point
Copy the full SHA aedcae4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 169c789 - Browse repository at this point
Copy the full SHA 169c789View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c580b8 - Browse repository at this point
Copy the full SHA 6c580b8View commit details
Commits on May 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 35cd8de - Browse repository at this point
Copy the full SHA 35cd8deView commit details -
Fix the skip_inner_frames test
Not all platforms support precisely locating the `symbol_address` for a frame which means that this test only works on platforms which do.
Configuration menu - View commit details
-
Copy full SHA for 35ec005 - Browse repository at this point
Copy the full SHA 35ec005View commit details
Commits on May 29, 2019
-
Configuration menu - View commit details
-
Copy full SHA for dd2ac2c - Browse repository at this point
Copy the full SHA dd2ac2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f573ae9 - Browse repository at this point
Copy the full SHA f573ae9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9c0985 - Browse repository at this point
Copy the full SHA f9c0985View commit details -
Looks like finding the enclosing function either isn't fully implemented or is buggy or something like that. In any case it's not working well enough that we can test it.
Configuration menu - View commit details
-
Copy full SHA for 77cf78d - Browse repository at this point
Copy the full SHA 77cf78dView commit details -
Finding the enclosing function doesn't work there either
Configuration menu - View commit details
-
Copy full SHA for c7172b6 - Browse repository at this point
Copy the full SHA c7172b6View commit details
Commits on May 30, 2019
-
Don't adjust the IP with libunwind
This was first introduced with the very first implementation of symbolication way back when in rust-lang/rust@bdd31b3, but nowadays it's not entirely clear that this is still necessary. In any case it's best to have the adjustment done in symbolication code rather than the return value of `Frame::ip`, so switch to returning an unadjusted instruction address. If this causes issues we can always have some offsets later on in the return values!
Configuration menu - View commit details
-
Copy full SHA for 901f1f6 - Browse repository at this point
Copy the full SHA 901f1f6View commit details -
Merge pull request #192 from rust-lang/maybe-not-adjust
Don't adjust the IP with libunwind
Configuration menu - View commit details
-
Copy full SHA for 17cb244 - Browse repository at this point
Copy the full SHA 17cb244View commit details
Commits on Jun 3, 2019
-
Move aux crates in a
crates
directoryJust an internal refactoring before more are added.
Configuration menu - View commit details
-
Copy full SHA for f15a3e9 - Browse repository at this point
Copy the full SHA f15a3e9View commit details -
Add a test that without debuginfo symbols still resolve
Almost all platforms should still have some degree of symbolication without debug symbols being present (aka the dynamic symbol table and such), so add a test asserting that symbols do indeed come out in these scenarios. This test will likely need to be blacklisted for platforms over time, but that's ok.
Configuration menu - View commit details
-
Copy full SHA for 0f7946f - Browse repository at this point
Copy the full SHA 0f7946fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 577e602 - Browse repository at this point
Copy the full SHA 577e602View commit details -
Add a test that without debuginfo symbols still resolve
Almost all platforms should still have some degree of symbolication without debug symbols being present (aka the dynamic symbol table and such), so add a test asserting that symbols do indeed come out in these scenarios. This test will likely need to be blacklisted for platforms over time, but that's ok.
Configuration menu - View commit details
-
Copy full SHA for c15b7a3 - Browse repository at this point
Copy the full SHA c15b7a3View commit details -
Fall back to
dladdr
on Unix in more placesCurrently CoreSymbolication will fall back to `dladdr` but this also applies the same logic to the `libbacktrace` symbolication strategy since libbacktrace (especially on OSX) can't always get symbol name information. Instead these platforms will all fall back to `dladdr` if no symbol information is learned from libbacktrace. This involved some refactoring internally since all invocations calling the `dladdr` function are now shared instead of having three separate ones throughout.
Configuration menu - View commit details
-
Copy full SHA for 861faf1 - Browse repository at this point
Copy the full SHA 861faf1View commit details -
Merge pull request #196 from rust-lang/work-without-debuginfo
Fall back to `dladdr` on Unix in more places
Configuration menu - View commit details
-
Copy full SHA for 21f4d73 - Browse repository at this point
Copy the full SHA 21f4d73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b8f697 - Browse repository at this point
Copy the full SHA 7b8f697View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0.3.25...0.3.27