Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/backtrace-rs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.3.44
Choose a base ref
...
head repository: rust-lang/backtrace-rs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.3.45
Choose a head ref
  • 5 commits
  • 4 files changed
  • 4 contributors

Commits on Feb 26, 2020

  1. Upgrade goblin to 0.2 (#295)

    cuviper authored Feb 26, 2020
    Configuration menu
    Copy the full SHA
    4200442 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2020

  1. Configuration menu
    Copy the full SHA
    e2e23c8 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. Build libbacktrace with mmapio.c instead of read.c (except on Windows) (

    #298)
    
    Fixes #289
    
    `mmap` should be available on all platforms we support (except Windows),
    so we can use `libbacktrace`'s more efficient mmap-based code.
    Aaron1011 authored Mar 3, 2020
    Configuration menu
    Copy the full SHA
    c5f56d1 View commit details
    Browse the repository at this point in the history
  2. gimli: Implement symbol table searches on macOS (#300)

    If dwarf debug info isn't available we fall back to searching the symbol
    table. Typically this is done with `dladdr` on most platforms but with
    gimli we typically have all the infrastructure already in place to do
    the search ourselves. This functionality was already filled out on
    Linux and Windows, but it wasn't implemented on macOS yet because it
    wasn't necessary.
    
    Implementing a pretty simple version, however, shows substantial
    speedups for the various benchmarks. Presumably `dladdr` isn't exactly
    the fastest thing in the world and our sorted list search which is
    cached must be much faster here!
    
    The current comparison of before/after this change looks like:
    
    ```
     name                                 before ns/iter  after ns/iter  diff ns/iter   diff %  speedup
     new                                  81,472          9,047               -72,425  -88.90%   x 9.01
     new_unresolved                       2,126           2,009                  -117   -5.50%   x 1.06
     new_unresolved_and_resolve_separate  82,252          9,134               -73,118  -88.90%   x 9.01
     trace                                1,273           1,185                   -88   -6.91%   x 1.07
     trace_and_resolve_callback           67,403          2,123               -65,280  -96.85%  x 31.75
     trace_and_resolve_separate           76,452          2,822               -73,630  -96.31%  x 27.09
    ```
    alexcrichton authored Mar 3, 2020
    Configuration menu
    Copy the full SHA
    ac175e2 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Bump version numbers

    alexcrichton committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    a9d6076 View commit details
    Browse the repository at this point in the history
Loading