josh-sync: Replace #xxxx-style links in messages
#955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urgau
reviewed
Jun 14, 2025
| @@ -77,6 +80,7 @@ impl GitSync { | |||
| "--depth=1", | |||
| ]); | |||
| let new_summary = check_output(["git", "log", "-1", "--format=%h %s", &new_upstream_base]); | |||
| let new_summary = replace_references(&new_summary, &self.upstream_repo); | |||
There was a problem hiding this comment.
If this interest you, in triagebot bot we are using this regex, https://github.com/rust-lang/triagebot/blob/1657187393c4ed9979dfab3901a67b4b832cade0/src/handlers/issue_links.rs#L18-L19
There was a problem hiding this comment.
Oh that's great, I had no idea \B was a thing. Thanks!
There was a problem hiding this comment.
To avoid false positives (like #123az) I would also highly recommend using \b at the end.
There was a problem hiding this comment.
Indeed, missed that. Added, thanks
f5d0ed0 to
b8065de
Compare
fbstj
reviewed
Jun 14, 2025
Often our short summaries will pick up a Bors "Auto merge of #xxxx ...` commit message. Replace these with something like `rust-lang/rust#1234` to avoid broken links when going between repositories.
5f1732f to
a67d3e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often our short summaries will pick up a Bors "Auto merge of #xxxx ...
commit message. Replace these with something likerust-lang/rust#1234` to avoid broken links when going between repositories.