"Go to latest version" should ignore yanked versions

[Kinrany]

Clicking "Go to latest version" at https://docs.rs/futures/0.1.28/futures/ opens the docs for version 0.2.3-docs-yank.4 and then redirects back to 0.1.28.

Expected behavior:
should open the latest non-yanked version, 0.2.1.
should not display "Go to latest version" since 0.1.28 is already the latest version;
for 0.1.27 should open 0.1.28 directly instead of opening the yanked version first.

Related: #112, #221

[Kinrany]

Yanked versions should be filtered from &crate_details.versions here:

docs.rs/src/web/rustdoc.rs

Line 241 in 5727d15

let latest_version = latest_version(&crate_details.versions, &version);

[QuietMisdreavus]

Would this get fixed by #322?

[Kinrany]

Would this get fixed by #322?

It's related: would allow replacing the snippet above with

let versions_without_yanked = &crate_details.versions
    .filter(|v| !&crate_details.yanked.contains(v));
let latest_version = latest_version(versions_without_yanked, &version);

[Kinrany]

Oh wait, yanked is a bool, not a list of yanked versions.

[Kinrany]

Still related. #396 (comment) would apply if you added yanked_versions to CrateDetails in addition to yanked.

[Nemo157]

Should be fixed by #739, the futures crate is no longer a good testcase unfortunately, but there's internal tests covering it.