improve archive index reading performance #1541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
perhaps @Nemo157 has some improvement ideas on the deserializer? |
Nemo157
reviewed
Oct 31, 2021
d873206 to
1eeccd1
Compare
* use a streaming parser to find a file in the local index * switch to memmap as reader * use zero-copy deserialization for the key, change key data type
1eeccd1 to
b42ba77
Compare
jyn514
approved these changes
Nov 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the extreme case (
stm32ral, 1.2 million files in the archive) index-read gets from ~3.5s to600ms~300ms.This is the first time I worked with custom serde deserializers, I didn't find a way to:
I'm happy to add any improvements :)
There are still possible improvements when downloading the index, but for local indexes we probably don't have much more we can optimize without changing the format.