add subcommand to migrate old CBOR archive indexes to SQLite #2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nemo157 |
Nemo157
reviewed
Jul 8, 2023
Nemo157
approved these changes
Jul 30, 2023
|
I haven't tried running this on my instance yet, I'll do that soon. |
Nemo157
reviewed
Jul 30, 2023
this would be awesome. ( we should really have a staging env to test things like this with actual data) |
Nemo157
reviewed
Jul 31, 2023
Nemo157
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will give us a subcommand to migrate the existing cbor index files to SQLite, locally & on S3.
After the migration is done, I can simplify some of the logic in
storage::archive_indexand get rid of some depdendencies (cbor, mmap)I did a manual test with a handful of local indexes I had, but it would be awesome if @Nemo157 could run this migration on his test instance.