Skip to content

Fix regression when showing versions in dropdown #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jan 8, 2020

Closes #554

r? @koenaad

@pietroalbini pietroalbini merged commit 06d7607 into rust-lang:master Jan 8, 2020
@pietroalbini
Copy link
Member

Tested locally, it works.

@jyn514 jyn514 deleted the show-version-dropdown branch January 8, 2020 13:38
@yvrhdn
Copy link

yvrhdn commented Jan 8, 2020

Oops 🙈 glad this could be fixed so quickly. Thanks for the quick fix @jyn514
Weird the .hbs template didn't complain 😕

@jyn514
Copy link
Member Author

jyn514 commented Jan 8, 2020

Templates don't have any way to throw an error. {#each some_unknown_variable} just renders as blank.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Versions" dropdown no longer populated.
3 participants