Gracefully handle postgres pool timeouts #759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
reviewed
May 16, 2020
|
How did you test these changes? |
|
Testing was done via Apache's Does bring up the issue that the scoping of connections needs improvement, but that's another PR |
This would be really useful to determine how close we usually are to capacity btw! |
jyn514
approved these changes
May 18, 2020
|
Do you plan to add the pool capacity metric in this PR or in a followup? |
|
Sorry, I've just been a bit busy |
|
Thanks ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #626
docsrs_failed_db_connectionsmetric to monitor timed out database connections