Update ui test crate #2941
Merged
Update ui test crate #2941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
☀️ Test successful - checks-actions |
RalfJung
reviewed
Jun 26, 2023
| "--" => { | ||
| after_dashdash = true; | ||
| false | ||
| let mut quiet = false; |
There was a problem hiding this comment.
I can't find any place that this variable is actually used?
There was a problem hiding this comment.
oh no rustc, why hast thou forsaken me
RalfJung
reviewed
Jun 26, 2023
| TextAndGha, | ||
| ( | ||
| ui_test::status_emitter::Text, | ||
| ui_test::status_emitter::Gha::<false> { name: format!("{mode:?} {path} ({target})") }, |
There was a problem hiding this comment.
What does the false here mean?
There was a problem hiding this comment.
Turns off gha groups
There was a problem hiding this comment.
Suggested change
| ui_test::status_emitter::Gha::<false> { name: format!("{mode:?} {path} ({target})") }, | |
| ui_test::status_emitter::Gha::</* GHA groups */ false> { name: format!("{mode:?} {path} ({target})") }, |
bors
added a commit
that referenced
this pull request
Jun 27, 2023
Make `--quiet` actually do something address review from #2941 (comment)
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Jun 29, 2023
Make `--quiet` actually do something address review from rust-lang/miri#2941 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes:
status_emitteranymorerun_tests_generic