---

yaml
---
r: 5485
b: refs/heads/master
c: aabff48
h: refs/heads/master
i:
  5483: 6bcc403
v: v3

Author: pcwalton

[refs]

@@ -1,2 +1,2 @@
 ---
-refs/heads/master: d10d23f0ad4763642619d2d3e42f8150f7d91af3
+refs/heads/master: aabff480c92d7c72f8a8ff6652d328e6624585d5

trunk/src/rt/rust_abi.cpp

@@ -1,10 +1,35 @@
+// ABI-specific routines.
+
+#include <vector>
 #include <cstdlib>
 #include <stdint.h>
 #include "rust_abi.h"
 
+#define END_OF_STACK_RA     (void (*)())0xdeadbeef
+
 weak_symbol<uint32_t> abi_version("rust_abi_version");
 
 uint32_t get_abi_version() {
     return (*abi_version == NULL) ? 0 : **abi_version;
 }
 
+namespace stack_walk {
+
+std::vector<frame>
+backtrace() {
+    std::vector<frame> frames;
+
+    // Ideally we would use the current value of EIP here, but there's no
+    // portable way to get that and there are never any GC roots in our C++
+    // frames anyhow.
+    frame f(__builtin_frame_address(0), (void (*)())NULL);
+
+    while (f.ra != END_OF_STACK_RA) {
+        frames.push_back(f);
+        f.next();
+    }
+    return frames;
+}
+
+}   // end namespace stack_walk
+

trunk/src/rt/rust_abi.h

@@ -1,7 +1,10 @@
+// ABI-specific routines.
+
 #ifndef RUST_ABI_H
 #define RUST_ABI_H
 
 #include <cstdlib>
+#include <vector>
 
 #ifdef __WIN32__
 #include <windows.h>
@@ -36,6 +39,25 @@ class weak_symbol {
     T *&operator*() { fill(); return data; }
 };
 
+namespace stack_walk {
+
+struct frame {
+    uint8_t *bp;    // The frame pointer.
+    void (*ra)();   // The return address.
+
+    frame(void *in_bp, void (*in_ra)()) : bp((uint8_t *)in_bp), ra(in_ra) {}
+
+    inline void next() {
+        ra = *(void (**)())(bp + sizeof(void *));
+        bp = *(uint8_t **)bp;
+    }
+};
+
+std::vector<frame> backtrace();
+
+}   // end namespace stack_walk
+
+
 uint32_t get_abi_version();
 
 #endif

trunk/src/rt/rust_gc.cpp

@@ -18,24 +18,12 @@
 #include <dlfcn.h>
 #endif
 
-#define END_OF_STACK_RA     (void (*)())0xdeadbeef
+using namespace stack_walk;
 
 namespace gc {
 
 weak_symbol<const uintptr_t> safe_point_data("rust_gc_safe_points");
 
-struct frame {
-    uint8_t *bp;    // The frame pointer.
-    void (*ra)();   // The return address.
-
-    frame(void *in_bp, void (*in_ra)()) : bp((uint8_t *)in_bp), ra(in_ra) {}
-
-    inline void next() {
-        ra = *(void (**)())(bp + sizeof(void *));
-        bp = *(uint8_t **)bp;
-    }
-};
-
 struct root_info {
     intptr_t frame_offset;
     uintptr_t dynamic;  // 0 = static, 1 = dynamic
@@ -98,9 +86,7 @@ class gc {
 
 public:
     gc(rust_task *in_task) : task(in_task) {}
-
     void run();
-    std::vector<frame> backtrace();
 };
 
 const safe_point *
@@ -135,22 +121,6 @@ gc::sweep() {
     // TODO
 }
 
-std::vector<frame>
-gc::backtrace() {
-    std::vector<frame> frames;
-
-    // Ideally we would use the current value of EIP here, but there's no
-    // portable way to get that and there are never any GC roots in our C++
-    // frames anyhow.
-    frame f(__builtin_frame_address(0), (void (*)())NULL);
-
-    while (f.ra != END_OF_STACK_RA) {
-        frames.push_back(f);
-        f.next();
-    }
-    return frames;
-}
-
 void
 gc::run() {
     safe_point_map map;