Make the assertion in Ident::new debug-only.

nnethercote · cuviper · commit 281a20247021 · 2025-06-17T10:30:33.000-07:00
This fixes a perf regression introduced in #140252. (cherry picked from commit 4cb9f03)
diff --git a/compiler/rustc_span/src/symbol.rs b/compiler/rustc_span/src/symbol.rs
@@ -2353,7 +2353,7 @@ impl Ident {
     #[inline]
     /// Constructs a new identifier from a symbol and a span.
     pub fn new(name: Symbol, span: Span) -> Ident {
-        assert_ne!(name, kw::Empty);
+        debug_assert_ne!(name, kw::Empty);
         Ident { name, span }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -2353,7 +2353,7 @@ impl Ident {`
`2353`	`2353`	`#[inline]`
`2354`	`2354`	`/// Constructs a new identifier from a symbol and a span.`
`2355`	`2355`	`pub fn new(name: Symbol, span: Span) -> Ident {`
`2356`		`- assert_ne!(name, kw::Empty);`
	`2356`	`+ debug_assert_ne!(name, kw::Empty);`
`2357`	`2357`	`Ident { name, span }`
`2358`	`2358`	`}`
`2359`	`2359`