---

brson · brson · commit 4e1428cfb231 · 2011-08-30T21:08:07.000-07:00
yaml --- r: 5057 b: refs/heads/master c: 04928ed h: refs/heads/master i: 5055: 749fb47 v: v3
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: c94d4cff0314459f93e086b3ef0fd89f3f368f35
+refs/heads/master: 04928ed3f00e82d7d233d2b4d2a63440f098b279
diff --git a/trunk/src/lib/aio.rs b/trunk/src/lib/aio.rs
@@ -45,6 +45,9 @@ tag request {
 type ctx = chan<request>;
 
 fn ip_to_sbuf(ip: net::ip_addr) -> *u8 {
+    // FIXME: This is broken. We're creating a vector, getting a pointer
+    // to its buffer, then dropping the vector. On top of that, the vector
+    // created by istr::bytes is not null-terminated.
     vec::to_ptr(istr::bytes(net::format_addr(ip)))
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`---`
`2`		`-refs/heads/master: c94d4cff0314459f93e086b3ef0fd89f3f368f35`
	`2`	`+refs/heads/master: 04928ed3f00e82d7d233d2b4d2a63440f098b279`
Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,9 @@ tag request {`
`45`	`45`	`type ctx = chan<request>;`
`46`	`46`
`47`	`47`	`fn ip_to_sbuf(ip: net::ip_addr) -> *u8 {`
	`48`	`+ // FIXME: This is broken. We're creating a vector, getting a pointer`
	`49`	`+ // to its buffer, then dropping the vector. On top of that, the vector`
	`50`	`+ // created by istr::bytes is not null-terminated.`
`48`	`51`	`vec::to_ptr(istr::bytes(net::format_addr(ip)))`
`49`	`52`	`}`
`50`	`53`