Added comment to explain why only RustIstaller has llvm_tools = false.

kennytm · kennytm · commit ab5e3e66b57c · 2018-06-10T04:50:42.000+08:00
diff --git a/src/bootstrap/tool.rs b/src/bootstrap/tool.rs
@@ -340,6 +340,9 @@ macro_rules! tool {
     }
 }
 
+// FIXME(#51459): We have only checked that RustInstaller does not require
+// the LLVM binaries when running. We should go through all tools to determine
+// if they really need LLVM binaries, and make `llvm_tools` a required argument.
 tool!(
     Rustbook, "src/tools/rustbook", "rustbook", Mode::ToolRustc;
     ErrorIndex, "src/tools/error_index_generator", "error_index_generator", Mode::ToolRustc;

Original file line number	Diff line number	Diff line change
`@@ -340,6 +340,9 @@ macro_rules! tool {`
`340`	`340`	`}`
`341`	`341`	`}`
`342`	`342`
	`343`	`+// FIXME(#51459): We have only checked that RustInstaller does not require`
	`344`	`+// the LLVM binaries when running. We should go through all tools to determine`
	`345`	+// if they really need LLVM binaries, and make `llvm_tools` a required argument.
`343`	`346`	`tool!(`
`344`	`347`	`Rustbook, "src/tools/rustbook", "rustbook", Mode::ToolRustc;`
`345`	`348`	`ErrorIndex, "src/tools/error_index_generator", "error_index_generator", Mode::ToolRustc;`