Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/rust
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7d025f4b8
Choose a base ref
...
head repository: rust-lang/rust
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1861fb587
Choose a head ref
  • 15 commits
  • 92 files changed
  • 10 contributors

Commits on Apr 22, 2018

  1. smaller PR just to fix #50002

    @ExpHP @alexcrichton
    ExpHP authored and alexcrichton committed Apr 22, 2018
    Configuration menu
    Copy the full SHA
    7ef7f38 View commit details
    Browse the repository at this point in the history

  2. fix my unit test that was horrendously wrong 

    and add one for non-mut slicing since I touched that method too
    @ExpHP @alexcrichton
    ExpHP authored and alexcrichton committed Apr 22, 2018
    Configuration menu
    Copy the full SHA
    bbfc486 View commit details
    Browse the repository at this point in the history

  3. Revert stabilization of feature(never_type). 

    This commit is just covering the feature gate itself and the tests
that made direct use of `!` and thus need to opt back into the
feature.

A follow on commit brings back the other change that motivates the
revert: Namely, going back to the old rules for falling back to `()`.
    @pnkfelix @alexcrichton
    pnkfelix authored and alexcrichton committed Apr 22, 2018
    Configuration menu
    Copy the full SHA
    1bc6989 View commit details
    Browse the repository at this point in the history

  4. Bring back old fallback semantics: Without feature(never_type), fallb… 

    …ack to `()`, not `!`.

Note that this commit, since it is trying to be minimal in order to
ease backporting to the beta and release channels, does *not* include
the old future-proofing warnings that we used to have associated with
such fallback to `()`; see discussion at this comment:

#49691 (comment)
    @pnkfelix @alexcrichton
    pnkfelix authored and alexcrichton committed Apr 22, 2018
    Configuration menu
    Copy the full SHA
    e7c614b View commit details
    Browse the repository at this point in the history

  5. Revert "Stabilize the TryFrom and TryInto traits" 

    This reverts commit e53a2a7.
    @pnkfelix @alexcrichton
    pnkfelix authored and alexcrichton committed Apr 22, 2018
    Configuration menu
    Copy the full SHA
    d8cd933 View commit details
    Browse the repository at this point in the history

  6. Add back missing #![feature(never_type)]s

    @kennytm @alexcrichton
    kennytm authored and alexcrichton committed Apr 22, 2018
    Configuration menu
    Copy the full SHA
    c04b020 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2018

  1. Improve assertion in Query::force().

    @michaelwoerister
    michaelwoerister committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    eab568c View commit details
    Browse the repository at this point in the history

  2. TryFrom destabilization fixups

    @alexcrichton
    alexcrichton committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    1ca8ce9 View commit details
    Browse the repository at this point in the history

  3. Auto merge of #50175 - michaelwoerister:backport-e31dae4, r=alexcrichton 

    [beta] Backport - Improve assertion in Query::force().

Follow up to #49695 (comment)

r? @alexcrichton
    @bors
    bors committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    d7c60a1 View commit details
    Browse the repository at this point in the history

  4. Auto merge of #50182 - alexcrichton:beta-next, r=alexcrichton 

    [beta] Another round of backports

This is a backport of:

* #50039
* #50121
    @bors
    bors committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    5181002 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2018

  1. Only warn on erroneous promoted constants

    @oli-obk @pietroalbini
    oli-obk authored and pietroalbini committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    210d7fc View commit details
    Browse the repository at this point in the history

  2. always optimize test 

    The error messages differ between optimized and nonoptimized mode
    @oli-obk @pietroalbini
    oli-obk authored and pietroalbini committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    6308cc8 View commit details
    Browse the repository at this point in the history

  3. Warn on all erroneous constants

    @oli-obk @pietroalbini
    oli-obk authored and pietroalbini committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    731c704 View commit details
    Browse the repository at this point in the history

  4. Rename ui test flag compile-pass to must-compile-successfully

    @pietroalbini
    pietroalbini committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    656d825 View commit details
    Browse the repository at this point in the history

  5. Auto merge of #50224 - pietroalbini:beta-backports, r=alexcrichton 

    [beta] Process backports

* #49779: Don't report compile-time errors for promoteds
* #50110: Warn on all erroneous constants
    @bors
    bors committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    1861fb5 View commit details
    Browse the repository at this point in the history
Loading