Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/rust
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: sw17ch/rust
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: broken-codegen-with-non-c-like-enum
Choose a head ref
  • 7 commits
  • 28 files changed
  • 3 contributors

Commits on Jan 22, 2020

  1. Add a test that demonstrates a segfault when calling into rust with n… 

    …on-c-like-enum.
    @sw17ch
    sw17ch committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    7c061c2 View commit details
    Browse the repository at this point in the history

  2. Add a test that demonstrates an incorrect return value when calling i… 

    …nto rust with non-c-like-enums.
    @sw17ch
    sw17ch committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    20a2e8b View commit details
    Browse the repository at this point in the history

  3. Add similar examples that work to each test.

    @sw17ch
    sw17ch committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    2d0e857 View commit details
    Browse the repository at this point in the history

  4. Two test cases where Rust calls C using enums by value 

    One calls into C functions passing non-c-like enumerations by
value. The other calls into C expecting non-C-like enumerations as
returns.

These test cases are based on the tests provided by @bitwalker on
issue #68190. The original tests were provided at:
https://github.com/bitwalker/rust_non_c_like_enums_issue/tree/2688d5c672bd4e289085fcdf1c6110e99e7e8ab1
    @sw17ch
    sw17ch committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    650e5f8 View commit details
    Browse the repository at this point in the history

  5. rustc_target: switch homogeneous_aggregate to returning Result.

    @eddyb @sw17ch
    eddyb authored and sw17ch committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    d8d737b View commit details
    Browse the repository at this point in the history

  6. rustc_target: treat enum variants like union members, in call ABIs.

    @eddyb @sw17ch
    eddyb authored and sw17ch committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    cc2f018 View commit details
    Browse the repository at this point in the history

  7. Add non-C-like enumeration tests on Rust->C calls to the abi-sysv64-a… 

    …rg-passing test.
    @sw17ch
    sw17ch committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    b3ed14a View commit details
    Browse the repository at this point in the history
Loading