Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/rust
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 255aa22
Choose a base ref
...
head repository: jyn514/rust
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0e33cc5
Choose a head ref
  • 5 commits
  • 23 files changed
  • 1 contributor

Commits on Jan 4, 2023

  1. Ignore things in .gitignore in tidy 

    - Switch from `walkdir` to `ignore`. This required various changes to
  make `skip` thread-safe.
- Ignore `build` anywhere in the source tree, not just at the top-level.
  We support this in bootstrap, we should support it in tidy too.

As a nice side benefit, this also makes tidy a bit faster.

Before:
```
; hyperfine -i '"/home/gh-jyn514/rust2/build/aarch64-unknown-linux-gnu/stage0-tools-bin/rust-tidy" "/home/gh-jyn514/rust2" "/home/gh-jyn514/rust2/build/aarch64-unknown-linux-gnu/stage0/bin/cargo" "/home/gh-jyn514/rust2/build" "32"'
Benchmark 1: "/home/gh-jyn514/rust2/build/aarch64-unknown-linux-gnu/stage0-tools-bin/rust-tidy" "/home/gh-jyn514/rust2" "/home/gh-jyn514/rust2/build/aarch64-unknown-linux-gnu/stage0/bin/cargo" "/home/gh-jyn514/rust2/build" "32"
  Time (mean ± σ):      1.080 s ±  0.008 s    [User: 2.616 s, System: 3.243 s]
  Range (min … max):    1.069 s …  1.099 s    10 runs
```

After:
```
; hyperfine '"/home/gh-jyn514/rust2/build/aarch64-unknown-linux-gnu/stage0-tools-bin/rust-tidy" "/home/gh-jyn514/rust2" "/home/gh-jyn514/rust2/build/aarch64-unknown-linux-gnu/stage0/bin/cargo" "/home/gh-jyn514/rust2/build" "32"'
Benchmark 1: "/home/gh-jyn514/rust2/build/aarch64-unknown-linux-gnu/stage0-tools-bin/rust-tidy" "/home/gh-jyn514/rust2" "/home/gh-jyn514/rust2/build/aarch64-unknown-linux-gnu/stage0/bin/cargo" "/home/gh-jyn514/rust2/build" "32"
  Time (mean ± σ):     705.0 ms ±   1.4 ms    [User: 3179.1 ms, System: 1517.5 ms]
  Range (min … max):   702.3 ms … 706.9 ms    10 runs
```
    @jyn514
    jyn514 committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    d998000 View commit details
    Browse the repository at this point in the history

  2. tmp

    @jyn514
    jyn514 committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    270a005 View commit details
    Browse the repository at this point in the history

  3. wip: parallel-tidy

    @jyn514
    jyn514 committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    ac1b394 View commit details
    Browse the repository at this point in the history

  4. [wip] add a check step for tidy\n this allows running clippy on it

    @jyn514
    jyn514 committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    f8399f7 View commit details
    Browse the repository at this point in the history

  5. a miserable disappointment

    @jyn514
    jyn514 committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    0e33cc5 View commit details
    Browse the repository at this point in the history
Loading