Skip to content

GenericPath dirname and dirname_str should be removed #10035

Closed
@metajack

Description

@metajack

GenericPath defines dirname which returns a byte vector (why?) instead of a path, and a dirname_str which returns a str. Returning a str seems inconsistent with not returning a str very specifically in Path and having to go through Display. Why doesn't dirname just return a Path? That would allow us to remove dir_path.

Alternatively we could keep dir_path and remove dirname and dirname_str.

This module still needs some love.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions