Skip to content

Improve error about close delimiter #10636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
evilpie opened this issue Nov 24, 2013 · 0 comments · Fixed by #10641
Closed

Improve error about close delimiter #10636

evilpie opened this issue Nov 24, 2013 · 0 comments · Fixed by #10641
Labels
A-diagnostics Area: Messages for errors, warnings, and lints

Comments

@evilpie
Copy link

evilpie commented Nov 24, 2013

I wrote code like this for servo:

pub fn trace_option(tracer: *mut JSTracer, description: &str, option: Option<Reflector>) {
    option.map(|some| trace_reflector(tracer, description, some.reflector());
}

which was missing the closing ) for the map. The error however was about something different:
error: incorrect close delimiter: }``
@emberian emberian mentioned this issue Nov 25, 2013
Merged
bors added a commit that referenced this issue Nov 25, 2013
@bors
auto merge of #10641 : cmr/rust/close_delims, r=alexcrichton
ce32f72 
Currently, the parser doesn't give any context when it finds an unclosed
delimiter and it's not EOF. Report the most recent unclosed delimiter, to help
the user along.

Closes #10636
bors pushed a commit to rust-lang-ci/rust that referenced this issue Jan 28, 2025
@Centri3
Do not trigger redundant_pub_crate in external macros (rust-lang#13952
d648cc9 
)

Some widely used crates, such as `pin-project-lite`, make use of a
`pub(crate)` construct in a private module inside a public macro. This
makes unrelated project trigger the lint.

There is also an unfortunate situation for Clippy itself: when a new
version of `pin-project-lite` or similar lint-trigerring crates is
released, those lints which can be found in hundreds of occurrences in
dependent crates will change, and appear as diffs in unrelated Clippy PR
because the base lintcheck run will be cached with the ancient release
of the crates. We currently have the situation
[here](https://github.com/rust-lang/rust-clippy/actions/runs/12635410895?pr=13851#user-content-redundant-pub-crate-removed),
which 219 lints removed and 219 lints added because of a
`pin-project-lite` version change between runs, and the fact that
`redundant_pub_crate` triggers on external macros.

Also:
- Fix rust-lang#10636
- Fix rust-lang#12213

changelog: [`redundant_pub_crate`]: do not trigger on external macros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a note for unclosed delimiters
1 participant
@evilpie