dead_code shouldn't warn for unused exported methods when compiling tests

[sfackler]

If I have

pub fn foo() {}

pub fn bar() {}

#[test]
fn test_bar() { bar() }

and compile the tests, I get an unused code warning for foo but I probably shouldn't in this case.

[jfager]

I was thinking of reporting this the other way, i.e. using bar() in a test shouldn't mark it used. If you have otherwise dead code that's tested it seems like you'd still want to be alerted about it, wouldn't you?

Or is 'poor man's test coverage tool' a desired role for the dead code check?

[sfackler]

If it's only used in a test, it'll get a dead code warning when compiling in not-test mode.

[jfager]

Hmm. I have a project where 'rustpkg build' gives me dead code warnings for things that aren't covered by tests but nothing for things that are, but when I use rustc directly it works like you say. Not sure if that's expected...

[metajack]

rustpkg build will build test, bench, lib, and main if it finds those.

[jfager]

Okay, understood, but the net effect is that using rustpkg means I don't get dead code warnings when the only usage is in a test, right? That seems like a problem?

Granted it's not this problem, though, so I'm happy to stop clogging up this ticket talking about it.

[sfackler]

This doesn't seem to happen anymore (maybe dead_code is turned off entirely during tests?)