Unwinding instruction gets emitted regardless -Z no-landing-pads flag #11647
Comments
bors
added a commit
that referenced
this issue
Jan 21, 2014
Ericson2314
referenced
this issue
in pczarn/rustboot
May 28, 2014
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Jul 11, 2024
…-api, r=xFrednet Honor `avoid-breaking-exported-api` in `needless_pass_by_ref_mut` Until now, the lint only emitted a warning, when breaking public API. Now it doesn't lint at all when the config value is not set to `false`, bringing it in line with the other lints using this config value. Also ensures that this config value is documented in the lint. changelog: none (I don't think a changelog is necessary, since this lint is in `nursery`) --- Fixes rust-lang/rust-clippy#11374 cc `@GuillaumeGomez` Marking as draft: Does this lint even break public API? If I change a function signature from `fn foo(x: &mut T)` to `fn foo(x: &T)`, I can still call it with `foo(&mut x)`. The only "breaking" thing is that the `clippy::unnecessary_mut_passed` lint will complain that `&mut` at the callsite is not necessary, possibly trickling down to the crate user having to remote a `mut` from a variable. [Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=058165a7663902e84af1d23e35c10d66). Are there examples where this actually breaks public API, that I'm missing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The unwinding instructions are always emitted now with or without no-landing-pads flag. It worked a day ago but now is broken. This must be a regression introduced in the past day or so.
Reported to the rust-dev mailing list and confirmed by Daniel Micay.
cc #10916
The text was updated successfully, but these errors were encountered: