Reintroduce jemalloc #11807
Labels
A-runtime
Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Comments
|
Won't using different symbol names interfere with LLVM's libcall optimisations? (Of course, the net benefit of using jemalloc might still be positive.) |
|
@huonw Maybe, but if so we can fix llvm. |
bors
added a commit
that referenced
this issue
May 11, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Dec 1, 2023
[`redundant_guards`]: catch `is_empty`, `starts_with` and `ends_with` on slices and `str`s Fixes rust-lang#11807 Few things worth mentioning: - Taking `snippet`s is now done at callsite, instead of passing a span and doing it in `emit_redundant_guards`. This is because we now need custom suggestion strings in certain places, like `""` for `str::is_empty`. - This now uses `snippet` instead of `snippet_with_applicability`. I don't think this really makes any difference for `MaybeIncorrect`, though? - This could also lint byte strings, as they're of type `&[u8; N]`, but that can be ugly so I decided to leave it out for now changelog: [`redundant_guards`]: catch `str::is_empty`, `slice::is_empty`, `slice::starts_with` and `slice::ends_with`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would still be great to have our own, awesome allocator. I'd suggest building jemalloc in the mode where it doesn't attempt to replace the
mallocandfreefunctions but instead provides them under their own name, and modify std to use jemalloc directly.The text was updated successfully, but these errors were encountered: