-
Notifications
You must be signed in to change notification settings - Fork 13.4k
track renamed and removed library feature gates #141617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
this needs some api design. the current API looks like this: cc @rust-lang/libs-api, this mostly affects you. |
How difficult is this problem, I can assist with it. |
i expect the code to not be too bad; it's mostly the api that needs design. but all this stuff is super unstable anyway so i think it's fine to add something that works for now and we can go back and do api design later. the existing parsing lives around rust/compiler/rustc_attr_parsing/src/attributes/stability.rs Lines 290 to 292 in 30721b0
unstable_removed attribute; #![recursion_limit] is a crate-level attribute that isn't too complicated, you could use that as an example for your new code.
@rustbot label E-medium E-mentor E-help-wanted |
@rustbot claim |
Tracking the old name of renamed unstable library features This PR resolves the first problem of rust-lang#141617 : tracking renamed unstable features. The first commit is to add a ui test, and the second one tracks the changes. I will comment on the code for clarification. r? `@jdonszelmann` There have been a lot of PR's reviewed by you lately, thanks for your time! cc `@jyn514`
Rollup merge of #142158 - xizheyin:141617, r=jdonszelmann Tracking the old name of renamed unstable library features This PR resolves the first problem of #141617 : tracking renamed unstable features. The first commit is to add a ui test, and the second one tracks the changes. I will comment on the code for clarification. r? `@jdonszelmann` There have been a lot of PR's reviewed by you lately, thanks for your time! cc `@jyn514`
Tracking the old name of renamed unstable library features This PR resolves the first problem of rust-lang/rust#141617 : tracking renamed unstable features. The first commit is to add a ui test, and the second one tracks the changes. I will comment on the code for clarification. r? `@jdonszelmann` There have been a lot of PR's reviewed by you lately, thanks for your time! cc `@jyn514`
Tracking the old name of renamed unstable library features This PR resolves the first problem of rust-lang/rust#141617 : tracking renamed unstable features. The first commit is to add a ui test, and the second one tracks the changes. I will comment on the code for clarification. r? `@jdonszelmann` There have been a lot of PR's reviewed by you lately, thanks for your time! cc `@jyn514`
Uh oh!
There was an error while loading. Please reload this page.
Code
Current output
Desired output
Rationale and extra context
we have something like this for lang features, whose removal we explicitly track:
but there is no way to track this for libs features, which leads to unnecessarily confusing errors. it would be nice if we could help people out more here, especially since the people seeing this error are likely not the crate authors but just people who happen to be using a nightly toolchain.
Other cases
Rust Version
Anything else?
No response
The text was updated successfully, but these errors were encountered: