Rustdoc: Search shows incorrect paths for enum variants

[mahkoh]

E.g. http://doc.rust-lang.org/syntax/ast/enum.Expr_.html?search=ExprIndex shows syntax::ast::Expr_::ExprIndex but the correct path is syntax::ast::ExprIndex.

[gamazeps]

Is it really a bad thing ?
I mean this way we know that ExprIndex belongs to the enum Expr_, plus as the enum name is CamelCase there are no risk to mistake it for a file / folder.
We only gain info with this path, don't we ?

[mahkoh]

I see no point in using the :: path syntax if the path isn't the real path of the identifier. I was searching for ExprIndex and quickly dismissed the search results because I didn't see a path ending in ast::ExprIndex. Only after manually going to syntax::ast to see why Rustdoc didn't find it did I realize what is going on.

[tomjakubowski]

I imagine this was done originally because variants and types were in different namespaces. Now that they're in the same namespace rustdoc should use the real path as @mahkoh suggested.

[tomjakubowski]

If accepted, rust-lang/rfcs#390 would close this (although some variants might also be re-exported at the same level as the enum).

[tomjakubowski]

This can be closed now that #18481 is merged