Skip to content

std::io::TempDir::{new,new_from} should use &[u8] as their suffix instead of &str #19437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
codyps opened this issue Dec 1, 2014 · 4 comments
Closed

std::io::TempDir::{new,new_from} should use &[u8] as their suffix instead of &str #19437

codyps opened this issue Dec 1, 2014 · 4 comments

Comments

@codyps
Copy link
Contributor

codyps commented Dec 1, 2014

Paths can be constructed from &[u8], TempDir should allow the same.
@csouth3
Copy link
Contributor

csouth3 commented Dec 1, 2014

Looks like suffix could probably be a BytesContainer, actually. I could give this a shot if you (or someone else) aren't already working on it, and if it's a desired change.

@codyps
Copy link
Contributor Author

codyps commented Dec 1, 2014

@csouth3 go for it 👍

@csouth3
Copy link
Contributor

csouth3 commented Dec 1, 2014

Cool! I'll get a PR put together in the next couple of hours.

@csouth3 csouth3 mentioned this issue Dec 2, 2014
Closed
@alexcrichton
Copy link
Member

Closing for now for reasons here: #19447 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make std::io::TempDir::{new, new_in} accept a BytesContainer as a suffix csouth3/rust
3 participants
@alexcrichton @codyps @csouth3