Skip to content

Bitv/BitvSet's #[stable] mismatches collections reform RFC #21193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
huonw opened this issue Jan 15, 2015 · 1 comment
Closed

Bitv/BitvSet's #[stable] mismatches collections reform RFC #21193

huonw opened this issue Jan 15, 2015 · 1 comment
Labels
A-collections Area: `std::collections`
Milestone
1.0 beta

Comments

@huonw
Copy link
Member

huonw commented Jan 15, 2015

@nikomatsakis noticed that Bitv and BitvSet are marked #[stable] but collections reform 2 says:

Unstable: Bitv, BitvSet, VecMap

(Maybe there was further discussion not in the RFC, maybe not.)

cc @gankro, @aturon
@Gankra
Copy link
Contributor

Gankra commented Jan 15, 2015

Definitely an error in my stabilization pass.

@nagisa nagisa mentioned this issue Jan 15, 2015
Closed
@brson brson added this to the 1.0 beta milestone Jan 15, 2015
nagisa added a commit to nagisa/rust that referenced this issue Jan 16, 2015
@nagisa
Revert stability for Bitv and BitvSet
bc03bf8 
The collections were promoted to stable by mistake and do not match RFC 509.
This reverts the stability back to unstable.

[breaking-change] since previously stable API became unstable.

Fixes rust-lang#21193
@kmcallister kmcallister added the A-collections Area: `std::collections` label Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-collections Area: `std::collections`
Projects
None yet
Milestone
1.0 beta
Development

Successfully merging a pull request may close this issue.

Revert stability for Bitv and BitvSet nagisa/rust
4 participants
@brson @kmcallister @Gankra @huonw