Skip to content

Kill off stray operator-new in rust_task.h #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
graydon opened this issue Jun 21, 2012 · 2 comments
Closed

Kill off stray operator-new in rust_task.h #2697

graydon opened this issue Jun 21, 2012 · 2 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@graydon
Copy link
Contributor

graydon commented Jun 21, 2012

Not entirely sure why, but it seems unpopular with its author (eholk).
@eholk
Copy link
Contributor

eholk commented Jun 21, 2012

Huh, I don't remember why I didn't like this either. I think it was probably that we had a bunch of different new operators, and it was really easy to accidentally use the wrong one.

@alexcrichton alexcrichton mentioned this issue Apr 23, 2013
Closed
bors added a commit that referenced this issue Apr 23, 2013
@bors
auto merge of #6025 : alexcrichton/rust/issue-2697, r=catamorphism
212256b 
Closes #2697

I guess all of the uses weren't around any more, because everything continued to compile (at least on OSX). If bors doesn't like it for another platform I can try to track it down as well.
@alexcrichton
Copy link
Member

I think this can be closed now?

RalfJung pushed a commit to RalfJung/rust that referenced this issue Dec 3, 2022
@bors
Auto merge of rust-lang#2697 - Vanille-N:borrow-tracking, r=RalfJung
90118a1 
Reorganizing `stacked_borrows` in anticipation of a different model

These commits reorganize all the code inside the former `stacked_borrows` module and extract the part that really is specific to Stacked Borrows inside the `borrow_tracker/stacked_borrows` submodule.
Everything not specific to SB is put in `borrow_tracker/mod.rs`.
This is so that the future Tree Borrows model can be later added as a second submodule and reuse all the contents of `borrow_tracker/mod.rs`.

This reorganization is accompanied by renamings, mostly from "stacked borrows" to "borrow tracking".
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2697 - Vanille-N:borrow-tracking, r=RalfJung
cfa28cf 
Reorganizing `stacked_borrows` in anticipation of a different model

These commits reorganize all the code inside the former `stacked_borrows` module and extract the part that really is specific to Stacked Borrows inside the `borrow_tracker/stacked_borrows` submodule.
Everything not specific to SB is put in `borrow_tracker/mod.rs`.
This is so that the future Tree Borrows model can be later added as a second submodule and reuse all the contents of `borrow_tracker/mod.rs`.

This reorganization is accompanied by renamings, mostly from "stacked borrows" to "borrow tracking".
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@github-actions @celinval
Automatic toolchain upgrade to nightly-2023-08-19 (rust-lang#2697)
931b1bb 
Co-authored-by: celinval <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@graydon @alexcrichton @eholk @catamorphism